New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSH #415

Closed
kotakanbe opened this Issue Apr 4, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@kotakanbe
Member

kotakanbe commented Apr 4, 2017

There are 2 patterns of vuls's SSH method.

  1. Go Library
  2. External Command

In the current implementation, if you do not specify any options, it is 1.
If -ssh-external is specified, it becomes 2.

The method of 1. was prepared for environments that do not contain SSH commands like windows, but it seems unnecessary. Because no one setups Vuls on Windows.

Furthermore, when implementing SSH host key check by the method of 1, it seems to be difficult...

So, I'm thinking like this.

  • Delete ssh-external option and add ssh-native-insecure option ( Default: ssh external command)
  • Add SSH host key check logic to 2
  • Watch whether Issues will not come up

@kotakanbe kotakanbe changed the title from Remove SSH Go native to Improve SSH Apr 4, 2017

@kotakanbe kotakanbe modified the milestone: v0.4.0 Apr 4, 2017

@knqyf263 knqyf263 closed this in #416 Apr 6, 2017

@kotakanbe kotakanbe reopened this Apr 6, 2017

@knqyf263 knqyf263 closed this in #417 Apr 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment