New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hipchat support #593

Merged
merged 4 commits into from Mar 6, 2018

Conversation

Projects
None yet
2 participants
@kazuminn
Contributor

kazuminn commented Jan 24, 2018

What did you implement:

Closes #203

How did you implement it:

How can we verify it:

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@kazuminn kazuminn changed the title from hipchat support to [WIP] hipchat support Jan 24, 2018

@kazuminn kazuminn changed the title from [WIP] hipchat support to hipchat support Jan 27, 2018

@kazuminn kazuminn changed the title from hipchat support to [wip]hipchat support Jan 29, 2018

@kazuminn kazuminn changed the title from [wip]hipchat support to [WIP]hipchat support Jan 29, 2018

Show outdated Hide outdated report/hipchat.go
Show outdated Hide outdated report/hipchat.go
type HipChatWriter struct{}
func (w HipChatWriter) Write(rs ...models.ScanResult) (err error) {
conf := config.Conf.HipChat

This comment has been minimized.

@kotakanbe

kotakanbe Feb 12, 2018

Member

I think these local variables (conf, room and token) have no meaning.
Use config.Conf.conf, room, token directory.

@kotakanbe

kotakanbe Feb 12, 2018

Member

I think these local variables (conf, room and token) have no meaning.
Use config.Conf.conf, room, token directory.

@kotakanbe

This comment has been minimized.

Show comment
Hide comment

@kazuminn kazuminn changed the title from [WIP]hipchat support to hipchat support Feb 26, 2018

@kazuminn

This comment has been minimized.

Show comment
Hide comment
@kazuminn

kazuminn Feb 27, 2018

Contributor

👍

Contributor

kazuminn commented Feb 27, 2018

👍

@kazuminn

This comment has been minimized.

Show comment
Hide comment
@kazuminn

kazuminn Mar 3, 2018

Contributor

Done document writing.

Contributor

kazuminn commented Mar 3, 2018

Done document writing.

kazuminn and others added some commits Jan 24, 2018

@kotakanbe kotakanbe referenced this pull request Mar 6, 2018

Closed

Add HipChat Support #203

@kotakanbe kotakanbe merged commit 26418be into future-architect:master Mar 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

kotakanbe added a commit that referenced this pull request Mar 7, 2018

Merge branch 'master' into v0.5.0
* master:
  fix: validation for reporting (#610)
  fix: remove a validation of hipchat (#609)
  hipchat support (#593)

kotakanbe added a commit that referenced this pull request Mar 7, 2018

Merge branch 'v0.5.0' into nvd-json
* v0.5.0:
  fix: validation for reporting (#610)
  fix: remove a validation of hipchat (#609)
  hipchat support (#593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment