Skip to content

commands: simplify s[:] to s #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kotakanbe merged 1 commit into from
Oct 4, 2018
Merged

commands: simplify s[:] to s #715

kotakanbe merged 1 commit into from
Oct 4, 2018

Conversation

@quasilyte
Copy link
Contributor

@quasilyte quasilyte commented Oct 3, 2018

If s is a slice, then s[:] is identical to just s.

Signed-off-by: Iskander Sharipov quasilyte@gmail.com

@quasilyte
commands: simplify s[:] to s
fe6868c 
If s is a slice, then `s[:]` is identical to just `s`.

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
@quasilyte quasilyte mentioned this pull request Oct 3, 2018
Closed
@kotakanbe kotakanbe merged commit 6da8b3c into future-architect:master Oct 4, 2018
@kotakanbe
Copy link
Member

kotakanbe commented Oct 4, 2018

Many Thanks!

@quasilyte quasilyte deleted the quasilyte/unslice branch October 4, 2018 04:06
kotakanbe added a commit that referenced this pull request Oct 4, 2018
@kotakanbe
Merge branch 'master' into show-repo
97ff068 
* master:
  config: remove commented-out code from tomlloader (#714)
  commands: simplify `s[:]` to s (#715)
  report: simplify `x = x <op> y` to `x <op>= y` (#716)
  change syslog pkg (#717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@quasilyte @kotakanbe