Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRestructure example Go #3
Closed
Comments
|
Sounds right. will be happy for a PR. |
yevgenypats
added a commit
that referenced
this issue
Aug 2, 2019
|
Closing as this was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For a library, an idiomatic Go way of structuring it would be to have the code at the top-level instead of in
pkg/parser.Such naming is usually used when the top-level is an application but the repo also contains re-usable (by others) packages, in which case those re-usable packages are under
pkg/.Also,
go-fuzz-builddoesn't support multiple-packages sogo-fuzz-build -libfuzzer -o fuzzer.a ./...doesn't work in general case.It only happens to work because there's only one package in this example
This should be
go-fuzz-build -libfuzzer -o fuzzer.a .or ``go-fuzz-build -libfuzzer -o fuzzer.a github.com/fuzzitdev/example-go`I can make a PR.