Skip to content

/ example-go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable modules in ci integration script #4

Closed
kjk opened this issue Aug 2, 2019 · 2 comments
Closed

Disable modules in ci integration script #4

kjk opened this issue Aug 2, 2019 · 2 comments

Comments

@kjk
Copy link
Contributor

@kjk kjk commented Aug 2, 2019

go-fuzz doesn't support modules (see dvyukov/go-fuzz#195) so we should add:

export GO111MODULE="off"

at the top of fuzzit.sh (like I had to do in gomarkdown/markdown@f70ab62).

Otherwise, things will break for packages that use modules.

I can make a PR.
@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 2, 2019

Doesn't go-fuzz already set GO11MODULE="off"? if not then please open a PR as you suggested.
yevgenypats added a commit that referenced this issue Aug 2, 2019
@yevgenypats
Merge pull request #5 from kjk/tweak-example
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ab41121 
restructure example and tweak readme (fixes issue #3; fixes issue #4)
@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 2, 2019

Closing as this was merged.
@yevgenypats yevgenypats closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@kjk @yevgenypats
You can’t perform that action at this time.