Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify by adding -auth to `create job` #10

Closed
kjk opened this issue Aug 2, 2019 · 3 comments
Closed

simplify by adding -auth to `create job` #10

kjk opened this issue Aug 2, 2019 · 3 comments

Comments

@kjk
Copy link
Contributor

@kjk kjk commented Aug 2, 2019

Currently to create a job, one has to do:

./fuzzit auth ${FUZZIT_API_KEY}
export TARGET_ID=2n6hO2dQzylLxX5GGhRG
./fuzzit create job --type $1 --branch $TRAVIS_BRANCH --revision $TRAVIS_COMMIT $TARGET_ID ./fuzzer

It could be simplified to:

./fuzzit create job --auth ${FUZZIT_API_KEY} --type $1 --branch $TRAVIS_BRANCH --revision $TRAVIS_COMMIT $TARGET_ID ./fuzzer

or:

./fuzzit create job --api-key ${FUZZIT_API_KEY} --type $1 --branch $TRAVIS_BRANCH --revision $TRAVIS_COMMIT $TARGET_ID ./fuzzer
@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 2, 2019

but the ./fuzzit auth is only needed once and not before every create job. Do you still think this will be more convenient?

@kjk
Copy link
Contributor Author

@kjk kjk commented Aug 2, 2019

I'm thinking one step is better than two.

Less docs to write, less things to get wrong when user copy & pastes the commands.

On a CI system things start from scratch, so the caching doesn't happen anyway.

@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 10, 2019

This is now solved via --api-key that can be either passed as a flag or as an environment variable FUZZIT_API_KEY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.