Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve create target --seed #15

Open
kjk opened this issue Aug 2, 2019 · 2 comments
Open

improve create target --seed #15

kjk opened this issue Aug 2, 2019 · 2 comments

Comments

@kjk
Copy link
Contributor

@kjk kjk commented Aug 2, 2019

  1. It should also accept .zip files as it's more widely supported than tar.gz

  2. It should validate that the file given is in valid format (.tar.gz or .zip) before uploading it

@kjk
Copy link
Contributor Author

@kjk kjk commented Aug 2, 2019

Also validate the directory structure inside the archive is correct.

Can I just archive top-level files (say, foo.html, bar.html) or do they have to be in a directory (like corpus/foo.html and corpus/bar.html)?

Is the directory name significant?

@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 2, 2019

Actually it must be top-level files without a directory inside. Agree that some sort of validation is needed. Also agree on the .zip though it will need some tweaks on the backend so let's leave this Issue open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.