Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --if-not-exists option to fuzzit create target #25

Closed
kjk opened this issue Aug 11, 2019 · 5 comments
Closed

add --if-not-exists option to fuzzit create target #25

kjk opened this issue Aug 11, 2019 · 5 comments

Comments

@kjk
Copy link
Contributor

@kjk kjk commented Aug 11, 2019

In integration scripts I'm doing: ./fuzzit create target ${TARGET} || true

This is to make the script continue if it fails because the target already exists.

Unfortunately it suppresses all other errors (e.g. failure to authenticate).

Would be good to have --if-not-exists option which would do nothing and return success if target already exists.

@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 11, 2019

I'm not sure I agree that a target should be created as part of the CI script.
Target should be created only once (and possibly configured either via the CLI or the UI).
What runs in the CI should be only those actions that are needed to run every push/PR.

@kjk
Copy link
Contributor Author

@kjk kjk commented Aug 11, 2019

I understand that position.

However, not doing that from the script makes our job of preparing scripts for projects harder because it requires more steps from them and more explanations from us.

To simplify things, even more, we could remove "create target" from cli and have it be implicit in "create job".

Since the only way to upload fuzzing job is from cli, we could get rid of the "Create Target" flow in the UI.

@kjk
Copy link
Contributor Author

@kjk kjk commented Aug 11, 2019

Well, the wrinkle is the -seed option, so maybe we do need create target

@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 11, 2019

I get your idea though for me the "seamless" target creation is more confusing. Though maybe it is just me. let's keep this issue open for now and see if more people have a need for this feature.

@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 24, 2019

Ok added. here is also the use-case for reference

envoyproxy/envoy#7509 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.