Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse order of args to copyFile #8

Closed
kjk opened this issue Aug 2, 2019 · 1 comment
Closed

reverse order of args to copyFile #8

kjk opened this issue Aug 2, 2019 · 1 comment

Comments

@kjk
Copy link
Contributor

@kjk kjk commented Aug 2, 2019

In Go, the order for copy()-like operations should be copy(dst, src) see e.g. https://golang.org/pkg/io/#Copy

I can make a PR.

yevgenypats added a commit that referenced this issue Aug 2, 2019
#8 reverse args CopyFile
#3 validate --type param
#5 go fmt
#2 remove json tags
#6 unportable code
@yevgenypats
Copy link
Collaborator

@yevgenypats yevgenypats commented Aug 2, 2019

fixed

@yevgenypats yevgenypats closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.