Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptry to prevent being stuck forever if cache file gets corrupted #13
Conversation
| if err != nil { | ||
| return err | ||
| } | ||
| defer file.Close() |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kjk
Aug 2, 2019
Author
Contributor
It's moved after json.NewDecoder() because on e.g. windows one cannot remove opened file so we have to call file.Close() before os.Remove() and defer file.Close() means it would be called after.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kjk commentedAug 2, 2019
If
.fuzzit.cachegets corrupted so that it can't be json-decoded,fuzzit authwill be stuck forever.Try to prevent that by deleting the file if it fails decoding.