This repository was archived by the owner on Apr 30, 2021. It is now read-only.
try to prevent being stuck forever if cache file gets corrupted #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yevgenypats
reviewed
Aug 2, 2019
| if err != nil { | ||
| return err | ||
| } | ||
| defer file.Close() |
Contributor
There was a problem hiding this comment.
Why this line is removed?
Contributor
Author
There was a problem hiding this comment.
It's moved after json.NewDecoder() because on e.g. windows one cannot remove opened file so we have to call file.Close() before os.Remove() and defer file.Close() means it would be called after.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
.fuzzit.cachegets corrupted so that it can't be json-decoded,fuzzit authwill be stuck forever.Try to prevent that by deleting the file if it fails decoding.