Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary json tag annotation #2

Closed
wants to merge 1 commit into from

Conversation

@kjk
Copy link
Contributor

kjk commented Aug 2, 2019

In Go private struct fields (whose name starts with lowercase) are not serialized by json.Marshall so no need to annotate them with json:"-" tag.

yevgenypats added a commit that referenced this pull request Aug 2, 2019
#8 reverse args CopyFile
#3 validate --type param
#5 go fmt
#2 remove json tags
#6 unportable code
@yevgenypats
Copy link
Collaborator

yevgenypats commented Aug 2, 2019

I've fixed it in last commit to avoid merging the conflict from go-fmt.

@yevgenypats yevgenypats closed this Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.