New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple changes; python 2 support, dictionary, mutator refactor #26
Changes from 1 commit
9aa183f
a7b7264
d685d2d
895ee2f
ef2e1cf
acc996f
3a6fac5
b0cd504
ae27ac9
faa8e5f
beb0ce3
ecebfff
26d1e0e
0f78a24
6daa2b5
File filter...
Jump to…
Replace the timeout process kill with a terminate.
The kill operation is never a good choice for stopping a subprocess - it does not give the subprocess any chance to clean up. It's more usual to try a terminate and later kill if the process did not stop. More importantly to me, the kill method isn't present in the python 2 multiprocessing module.
- Loading branch information
| @@ -158,7 +158,7 @@ def start(self): | ||
| buf = self._corpus.generate_input() | ||
| parent_conn.send_bytes(bytes(buf)) | ||
gerph
Author
Contributor
|
||
| if not parent_conn.poll(self._timeout): | ||
| self._p.kill() | ||
| self._p.terminate() | ||
| logging.info("=================================================================") | ||
| logging.info("timeout reached. testcase took: {}".format(self._timeout)) | ||
| self.write_sample(buf, prefix='timeout-') | ||
Isn't it bytes already? I think this might slow down the fuzzer if it's an unnecessary copy.