Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet rid of numpy #46
Open
Get rid of numpy #46
Conversation
Numpy's types aren't doing much beside eating CPU and doing a simple wraparound, which can be done via a simple modulo. This commit also unroll a couple of loops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jvoisin commentedJun 10, 2020
Numpy's types aren't doing much beside eating CPU
and doing a simple wraparound, which can be done via a simple modulo.
This commit also unroll a couple of loops, and make use of unsigned numbers, which simplifies a bit the reasoning.