Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for dictionary files #6
Closed
Conversation
This commits adds the support for dictionaries (https://llvm.org/docs/LibFuzzer.html#dictionaries), to help fuzzers increase their coverage faster. It seems that there is a bug in the _copy function, because the word is correctly inserted, but it seems that the padding after it is wrong, and I couldn't understand why. Although to be honest, I didn't spent much time on it, since I'd like to have feedback on this PR before investing more debug time. The implementation is pretty crude, it silently ignore invalid lines in the dictionary file, and is likely using words in the corpus a bit too often.
|
I need to invest a bit more thought here as I didn't use this feature a lot at libfuzzer. If this is needed urgently I can merge it now and review later if you like as this being guarded by flag (maybe added experimental string in the help as well) |
|
It's not super-duper urgent :) I would prefer to have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jvoisin commentedDec 16, 2019
•
edited
This commits adds the support for dictionaries
(https://llvm.org/docs/LibFuzzer.html#dictionaries), to help fuzzers increase
their coverage faster.
It seems that there is a bug in the _copy function, because the word is
correctly inserted, but it seems that the padding after it is wrong,
and I couldn't understand why. Although to be honest,
I didn't spent much time on it, since I'd like to have feedback
on this PR before investing more debug time.
The implementation is pretty crude, it silently ignore
invalid lines in the dictionary file, and is likely using
words in the corpus a bit too often.