New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: find in project is showing incomplete/incorrect results in 1.18.0 beta #70

Closed
sbromberger opened this Issue May 17, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@sbromberger

sbromberger commented May 17, 2017

Hi,

Please ref: atom/find-and-replace#896, specifically atom/find-and-replace#896 (comment).

Summary is that "Find in Project" results are not correct when this theme (version 0.20.6) is enabled. Switching themes resolves the issue.

(I realize that beta support may be spotty, but I figure I'd give you a heads up anyway.)

This is on OSX 10.12.4.

@sbromberger

This comment has been minimized.

Show comment
Hide comment
@sbromberger

sbromberger May 17, 2017

Possibly related to #67?

sbromberger commented May 17, 2017

Possibly related to #67?

@DanFreed

This comment has been minimized.

Show comment
Hide comment
@DanFreed

DanFreed May 17, 2017

I can confirm this behavior as well. It looks like it is an "off by one" issue. It always shows 1 less line in the results than there actually are.

DanFreed commented May 17, 2017

I can confirm this behavior as well. It looks like it is an "off by one" issue. It always shows 1 less line in the results than there actually are.

@swrobel

This comment has been minimized.

Show comment
Hide comment
@swrobel

swrobel May 26, 2017

I'm seeing it as well in 1.17.2

swrobel commented May 26, 2017

I'm seeing it as well in 1.17.2

@DanFreed

This comment has been minimized.

Show comment
Hide comment
@DanFreed

DanFreed May 31, 2017

Anyone know how to patch the theme at least temporarily until an actual fix is released?

DanFreed commented May 31, 2017

Anyone know how to patch the theme at least temporarily until an actual fix is released?

@TheTourer

This comment has been minimized.

Show comment
Hide comment
@TheTourer

TheTourer Jun 1, 2017

Getting this as well. Troublingly, when there's only a single result per file, nothing shows at all, making the view effectively useless—can't action on anything that would open the file.

TheTourer commented Jun 1, 2017

Getting this as well. Troublingly, when there's only a single result per file, nothing shows at all, making the view effectively useless—can't action on anything that would open the file.

@fv0 fv0 added the Bug label Jun 2, 2017

@fv0 fv0 self-assigned this Jun 2, 2017

@fv0

This comment has been minimized.

Show comment
Hide comment
@fv0

fv0 Jun 3, 2017

Owner

@DanFreed: Anyone know how to patch the theme at least temporarily until an actual fix is released?

You can edit the theme and comment out the project-find-results.less file in index.less. This will put it back to its default state. I’m working on a fix at the moment though.

Owner

fv0 commented Jun 3, 2017

@DanFreed: Anyone know how to patch the theme at least temporarily until an actual fix is released?

You can edit the theme and comment out the project-find-results.less file in index.less. This will put it back to its default state. I’m working on a fix at the moment though.

@fv0 fv0 closed this in b30dd9d Jun 3, 2017

@sbromberger

This comment has been minimized.

Show comment
Hide comment
@sbromberger

sbromberger Jun 3, 2017

Thank you, @fv0! testing now.

sbromberger commented Jun 3, 2017

Thank you, @fv0! testing now.

@TheTourer

This comment has been minimized.

Show comment
Hide comment
@TheTourer

TheTourer Jun 6, 2017

Works again! Thanks so much @fv0; this theme makes Atom look like it should on macOS. It's the gold standard for native themes.

TheTourer commented Jun 6, 2017

Works again! Thanks so much @fv0; this theme makes Atom look like it should on macOS. It's the gold standard for native themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment