Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Images don't show up anymore #133

Open
fvcproductions opened this issue May 27, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@fvcproductions
Copy link
Owner

commented May 27, 2019

Describe the bug

Looks like JS/CSS is off and the card component has images that don't show up anymore along with the tags.

Expected behavior

CSS should display components properly and images should load.

Screenshots

Screen Shot 2019-05-27 at 7 37 07 PM

Additional context

I might consider switching to Bulma instead of Tailwind.

@fvcproductions fvcproductions added the bug label May 27, 2019

@issue-label-bot

This comment has been minimized.

Copy link

commented May 27, 2019

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@benjaminmodayil

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

@fvcproductions I ran NPM build locally and it updated the images. The paths got messed up. There's an error in the script for assigning the correct minified paths but I couldn't find the exact issue. This isn't a Tailwind problem, look at #134 and #132 for clarification on the styling issues.

@fvcproductions

This comment has been minimized.

Copy link
Owner Author

commented Jun 9, 2019

@benjaminmodayil This issue has been resolved - thanks again for the fix!

@benjaminmodayil

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

@fvcproductions Apparently the fix didn't take. I've reset it so the images are back up for now, but I'll need a deeper look into why the images keep getting messed up. I thought my previous "fix" would work, but I guess not.

@dpikt

This comment has been minimized.

Copy link

commented Jul 11, 2019

Images are not visible presently on the site. There's something up with the image paths script where it's setting the hash to undefined. That's as far as I could get, it's tough to debug because it works fine locally.

@benjaminmodayil

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

@dpikt Appreciate the help! Yeah, I'll look at this tonight. The latest build broke it.

The issue lies in the correct-image-paths.js file. Something here is off, but I haven't had time to diagnose it.

I have a temporary fix whenever this happens to update the image paths on Algolia, but requires the Algolia key I have on my home computer. At work at the moment, so I can't help fix it until evening.

@benjaminmodayil

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2019

Fixed... for now. Just ran "npm run build" and it updated Algolia.

Still needs a deeper look into the script in my last message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.