fix: Make sure timestamps are correctly passed

Author: fwal

packages/effect-firebase/src/lib/firestore/schema/timestamp.spec.ts

@@ -171,7 +171,10 @@ describe('TimestampDateTimeUtc', () => {
 
   describe('decoding', () => {
     it('should decode Timestamp to DateTime.Utc', () => {
-      const input = { seconds: 1705315800, nanoseconds: 123000000 };
+      const input = new Timestamp({
+        seconds: 1705315800,
+        nanoseconds: 123000000,
+      });
       const dt = decode(input);
 
       expect(DateTime.isDateTime(dt)).toBe(true);
@@ -191,10 +194,10 @@ describe('TimestampDateTimeUtc', () => {
   describe('roundtrip', () => {
     it('should maintain precision through roundtrip', () => {
       const originalMillis = 1705315800123;
-      const input = {
+      const input = new Timestamp({
         seconds: Math.floor(originalMillis / 1000),
         nanoseconds: (originalMillis % 1000) * 1000000,
-      };
+      });
       const dt = decode(input);
       const encoded = encode(dt);
 

packages/effect-firebase/src/lib/firestore/schema/timestamp.ts

@@ -34,11 +34,17 @@ export class Timestamp extends Schema.Class<Timestamp>('Timestamp')({
   }
 }
 
+/**
+ * Schema where Timestamp class instance is both Type and Encoded.
+ * Using instanceOf ensures the class instance is preserved through Schema.encode.
+ */
+export const TimestampInstance = Schema.instanceOf(Timestamp);
+
 /**
  * Schema representing a timestamp as a DateTime.Utc.
  */
 export const TimestampDateTimeUtc = Schema.transform(
-  Timestamp,
+  TimestampInstance,
   Schema.DateTimeUtcFromSelf,
   {
     decode: (ts) => DateTime.unsafeMake(ts.toMillis()),
@@ -54,8 +60,14 @@ export class ServerTimestamp extends Schema.Class<ServerTimestamp>(
   'ServerTimestamp'
 )({}) {}
 
+/**
+ * Schema where ServerTimestamp class instance is both Type and Encoded.
+ * Using instanceOf ensures the class instance is preserved through Schema.encode.
+ */
+export const ServerTimestampInstance = Schema.instanceOf(ServerTimestamp);
+
 export const AnyTimestampDateTimeUtc = Schema.transformOrFail(
-  Schema.Union(Timestamp, ServerTimestamp),
+  Schema.Union(TimestampInstance, ServerTimestampInstance),
   Schema.DateTimeUtcFromSelf,
   {
     strict: true,