From 4351a8d403cbfef78d2643efa0a51cf5dba9a4f1 Mon Sep 17 00:00:00 2001 From: fweber144 Date: Wed, 20 Apr 2022 08:32:18 +0200 Subject: [PATCH] Incorporate the fix for mclogit issue 24 (melff/mclogit#24). --- tests/testthat/test_proj_predfun.R | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/testthat/test_proj_predfun.R b/tests/testthat/test_proj_predfun.R index 8a1fc3de1..6a6088256 100644 --- a/tests/testthat/test_proj_predfun.R +++ b/tests/testthat/test_proj_predfun.R @@ -666,11 +666,11 @@ test_that(paste( })) if ((packageVersion("mclogit") <= "0.8.7.3" || packageVersion("mclogit") >= "0.9.4.1") && - FALSE) { # TODO: Replace `FALSE` by `packageVersion("mclogit") > "0.9.4.1"` (or similar) as soon as fixed in mclogit. + packageVersion("mclogit") >= "0.9.4.2") { # Not run for mclogit versions between 0.8.7.3 and 0.9.4.1 because of # mclogit's GitHub issue #23. - # Currently not run (for mclogit versions <= 0.9.4.1) because of mclogit's - # GitHub issue #24. + # Not run for mclogit versions < 0.9.4.2 because of mclogit's GitHub issue + # #24. expect_equal(unname(lpreds_orig_dummy), unname(lpreds_orig_dummy_man), tolerance = 1e-14) } @@ -739,11 +739,11 @@ test_that(paste( })) if ((packageVersion("mclogit") <= "0.8.7.3" || packageVersion("mclogit") >= "0.9.4.1") && - FALSE) { # TODO: Replace `FALSE` by `packageVersion("mclogit") > "0.9.4.1"` (or similar) as soon as fixed in mclogit. + packageVersion("mclogit") >= "0.9.4.2") { # Not run for mclogit versions between 0.8.7.3 and 0.9.4.1 because of # mclogit's GitHub issue #23. - # Currently not run (for mclogit versions <= 0.9.4.1) because of mclogit's - # GitHub issue #24. + # Not run for mclogit versions < 0.9.4.2 because of mclogit's GitHub issue + # #24. expect_equal(unname(lpreds_orig), unname(lpreds_orig_man), tolerance = 1e-14) }