Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuperIO Offline Updates get "stuck" #2830

Closed
Sean-StarLabs opened this issue Jan 29, 2021 · 4 comments · Fixed by #2835
Closed

SuperIO Offline Updates get "stuck" #2830

Sean-StarLabs opened this issue Jan 29, 2021 · 4 comments · Fixed by #2835
Labels
bug

Comments

@Sean-StarLabs
Copy link
Collaborator

If any update is scheduled for SuperIO, and something changes (such as entering S3, disconnecting the charger) before the update is installed, then the update will get "stuck".

The update then no longer appears in GNOME Software, and trying fwupdmgr update will show:

1f664ad149f2151fb750b52751dbf9ba045a7846 is already scheduled to be updated

It requires running sudo fwupdmgr clear-offline followed by a fwupdmgr update to get it to install.

I say this only knowing about the 3 plugins we use but would it not make sense to clear the pending updates each time the fwupd.service starts?
@hughsie
Copy link
Member

hughsie commented Jan 29, 2021

@superm1 makes sense to me; spot any logic problems? I guess we also need to check the boot time to avoid clearing it on idle quit.

@superm1
Copy link
Member

superm1 commented Jan 29, 2021

When does superio update get installed? It's only in a clean rebooted session right?

Yes, I think checking for a changed boot is a good enough criteria to mark any pending updates like that.

hughsie added a commit that referenced this issue Jan 30, 2021
@hughsie
Clear the pending flag if restarting the system
9243aca 
If any update is scheduled for SuperIO, and something changes (such as entering
S3, disconnecting the charger) before the update is installed, then the update
will get stuck.

Fixes #2830
@hughsie hughsie mentioned this issue Jan 30, 2021
Merged
4 tasks
@hughsie
Copy link
Member

hughsie commented Jan 30, 2021

Does #2835 work?

@Sean-StarLabs
Copy link
Collaborator Author

I have not been able to fault it :)

hughsie added a commit that referenced this issue Feb 3, 2021
@hughsie
Clear the pending flag if restarting the system
b2a1d97 
If any update is scheduled for SuperIO, and something changes (such as entering
S3, disconnecting the charger) before the update is installed, then the update
will get stuck.

Fixes #2830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear the pending flag if restarting the system fwupd/fwupd
3 participants
@hughsie @superm1 @Sean-StarLabs