Logitech bulk controller plugin initial commit

[vcdmp]

Type of pull request:

• [ x] New plugin (Please include new plugin checklist)
• Code fix
• Feature
• Documentation
• Fill out README.md with update protocol
• Fill out README.md with any custom quirks and flags
• Fill out README.md with the vendor ID security value
• Implement FuFirmware->write() and include at least one fuzzer testcase in src/fuzzing/firmware for any custom FuFirmware subclass
• CI run of the plugin for at least one target
• Document targets CI isn't currently run and the reasons (i.e. minimum versions needed or distribution limitations etc).

[superm1]

@djcampello: I think we need to add some extra stuff to clang format for protobuf:

Configuration file(s) do(es) not support Proto: /home/runner/work/fwupd/fwupd/.clang-format

[superm1]

Can you please add to dependencies.xml some development packages for protobuf in the various distros so that CI can run? Get at least one that you're familiar with done and we can help fill in the others if you can't find the package names for it.

[superm1]

Since master just had an ABI break for the plugin, I rebased on master and adjusted your code for that ABI break.
I also sorted out the dependencies needed for all the distros, so all of the CI should hopefully be building now, and hopefully I didn't break anything you had working.

Beyond a bunch of nits like function names and where to have prototypes and stuff - I think you have some error handling you need to adjust, and also some changed to store device data to subclassed devices instead of the plugin.

[superm1]

@djcampello: I think we need to add some extra stuff to clang format for protobuf:

Configuration file(s) do(es) not support Proto: /home/runner/work/fwupd/fwupd/.clang-format

@djcampello If you can please review what I did to clang-format to make protobuf stuff work, would appreciate it.

[superm1]

I tried and left some comments in the build script for our future selves on what it would take (technically) to enable Windows.
It's mostly blocked by https://bugzilla.redhat.com/show_bug.cgi?id=1991749.
If that's fixed some day, I would like to turn it on for CI at least, even if we exclude it from the EXE on tagged releases.

[djcampello]

@djcampello: I think we need to add some extra stuff to clang format for protobuf:

Configuration file(s) do(es) not support Proto: /home/runner/work/fwupd/fwupd/.clang-format

@djcampello If you can please review what I did to clang-format to make protobuf stuff work, would appreciate it.

This looks good to me. I am not completely familiar with per-language configuration but it looks good!

[superm1]

I have two very small open inquiries about this, but otherwise it looks good to me. Feel free to squash/force push my recent changes if you agree with them.

[superm1]

I have two very small open inquiries about this, but otherwise it looks good to me. Feel free to squash/force push my recent changes if you agree with them.

@vcdmp can you check those two nits and comment? I think we're ready to merge once you've answered those and tested the branch again.

[superm1]

LGTM, can you please squash into one commit?

[superm1]

LGTM, can you please squash into one commit?

squash your two I mean - leave the protobuf clang one separate