Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSP comments not correctly paired? <%-- %> instead of <%-- --%> #558

Closed
rorsach opened this issue Aug 7, 2015 · 2 comments
Closed

JSP comments not correctly paired? <%-- %> instead of <%-- --%> #558

rorsach opened this issue Aug 7, 2015 · 2 comments
Labels

Comments

@rorsach
Copy link

@rorsach rorsach commented Aug 7, 2015

JSP comments aren't correctly paired.

Typing <%- produces: <%-- %>.
I'm expecting: <%-- --%>

I don't really have the elisp skills to fix it, it seems. I poked around web-mode.el but nothing I tried fixed it, so I'm filing an issue for it now, hoping to get it fixed or for some tips on how to fix it.

Repro steps:

  1. Start emacs clean:

    > emacs -q
    
  2. Load only web-mode 12 (from melpa-stable)

    (load "c:/Users/myusername/AppData/Roaming/.emacs.d/elpa/web-mode-12/web-mode.el")
    
  3. Open JSP, load web-mode and enter start comment characters, note the auto inserted output is incorrect.

    M-x web-mode
    C-x C-f someJspFile.jsp
    M-x web-mode-set-engine RET jsp RET
    
@fxbois

This comment has been minimized.

Copy link
Owner

@fxbois fxbois commented Aug 8, 2015

@rorsach please test the latest commit

@rorsach

This comment has been minimized.

Copy link
Author

@rorsach rorsach commented Aug 9, 2015

Tested, validated working

Looking at the diff, I realize the fix was something I had tried. I think the reason I wasn't seeing my fix is because of the .elc file. Note to self: when editing packaged modes, byte compile them. :)

Thanks for the fix and for web-mode.

@rorsach rorsach closed this Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.