Check the file input

[kirs]

Otherwise it crashes when I run it without the first arguments:

$ bin/tkn

bin/tkn:277:in `mtime': no implicit conversion of nil into String (TypeError)
    from bin/tkn:277:in `block in <main>'
    from bin/tkn:274:in `loop'
    from bin/tkn:274:in `<main>'

(I wanted to run the tkn binary without args to see the help)

[fxn]

The first check is fine.

The second one... I don't like generally check exists? manually. That's
something you get automatically when you try to access the file. What if
the file exists but permissions are not enough?

In principle I'd prefer that control near the mtime and/or load calls.

El jueves, 8 de octubre de 2015, Kir Shatrov notifications@github.com
escribió:

Otherwise it crashes when I run it without the first arguments:

$ bin/tkn

bin/tkn:277:in mtime': no implicit conversion of nil into String (TypeError) from bin/tkn:277:inblock in

'
from bin/tkn:274:in loop' from bin/tkn:274:in'

(I wanted to run the tkn binary without args to see the help)

You can view, comment on, or merge this pull request online at:

#13
Commit Summary

• Check file input

File Changes

• M bin/tkn https://github.com/fxn/tkn/pull/13/files#diff-0 (11)

Patch Links:

• https://github.com/fxn/tkn/pull/13.patch
• https://github.com/fxn/tkn/pull/13.diff

—
Reply to this email directly or view it on GitHub
#13.

Sent from Gmail Mobile

[fxn]

Ah! Also no need for blank? here, this is the command line, checking ARGV.length or nil? would suffice.