Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test.NewTempApp() to tear down app at the end of the test #4850

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented May 18, 2024

Description:

Similar to #4849 but more about convenience than memory leaks.

There are also a few cases where we did not create a new app but only created a new one afterwards.
This PR should get us one step close towards being able to run tests in random order and hopefully get rid of strange order constraints when running the tests.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

@coveralls
Copy link

coveralls commented May 18, 2024

Coverage Status

coverage: 65.68% (-0.007%) from 65.687%
when pulling 39089be on Jacalz:temp-test-app
into 237167e on fyne-io:develop.

andydotxyz
andydotxyz previously approved these changes Jun 17, 2024
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this does read better than the defer and app creation pair

@Jacalz
Copy link
Member Author

Jacalz commented Jun 17, 2024

Thanks. Had to fix a merge conflict. Needs a re-approval, I'm afraid

@Jacalz Jacalz requested a review from andydotxyz June 17, 2024 19:37
@Jacalz Jacalz merged commit 759df6f into fyne-io:develop Jun 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants