Introduced the ability to specify the timezone for dateTimeThis*() methods #1090

Merged
merged 1 commit into from Dec 21, 2016

Projects

None yet

3 participants

@telkins
Contributor
telkins commented Nov 16, 2016

Introduced the ability to specify the timezone for the following methods:

  • dateTimeThisCentury(),
  • dateTimeThisDecade(),
  • dateTimeThisYear(), and
  • dateTimeThisMonth().

Updated readme and introduced new unit tests.

@telkins telkins Introduced the ability to specify the timezone for dateTimeThisCentur…
…y(), dateTimeThisDecade(), dateTimeThisYear(), and dateTimeThisMonth(). Updated readme and introduced new unit tests.
6324fa5
@telkins telkins changed the title from Introduced the ability to specify the timezone for dateTimeThis*() methods Centur… to Introduced the ability to specify the timezone for dateTimeThis*() methods Nov 16, 2016
@curry684
Contributor

Seems good to me. I do also think the global timezone setting would be a good idea, ie.:

$faker = Faker\Factory::create('nl_NL');
$faker->setTimezone('Europe/Amsterdam');

All the methods taking a timezone parameter should then default to the one in Faker, which itself should default to UTC.

@telkins
Contributor
telkins commented Nov 17, 2016

@curry684 I've just taken a look at all of the open PRs. They go back quite a ways. Who maintains this repository and how often are PRs and isues and such addressed...?

Btw, I like your suggestion to allow for a global timezone setting. I might take some time to do it in another PR...if it seems like someone might act on it. :-)

@curry684
Contributor

To my knowledge @fzaninotto is the only maintainer and this project is not a high priority, but he does merge good PRs in timely fashion from what I've seen.

@telkins
Contributor
telkins commented Dec 20, 2016

@fzaninotto Could you take a quick look at this PR and let me know if there's anything I can do to improve it? It would be much appreciated. Thanks...! :-)

@fzaninotto fzaninotto merged commit 56ff6fa into fzaninotto:master Dec 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fzaninotto
Owner

Thanks for your contribution, and sorry for the delay.

@telkins
Contributor
telkins commented Dec 21, 2016

NP. Thanks for your time. Much appreciated...! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment