Indian states added to en_IN locale #1131

Merged
merged 3 commits into from Jan 5, 2017

Projects

None yet

2 participants

@jiveshsg
jiveshsg commented Jan 3, 2017

Indian states added to en_IN locale

src/Faker/Provider/en_IN/Address.php
@@ -28,6 +27,14 @@ class Address extends \Faker\Provider\Address
'Warangal',
);
+ protected static $state = array(
+ 'Andhra Pradesh', 'Arunachal Pradesh', 'Assam', 'Bihar', 'Chhattisgarh', 'Goa', 'Gujarat', 'Haryana', 'Himachal Pradesh', 'Jammu and Kashmir', 'Jharkhand', 'Karnataka', 'Kerala', 'Madhya Pradesh', 'Maharashtra', 'Manipur', 'Meghalaya', 'Mizoram', 'Nagaland', 'Odisha', 'Punjab', 'Rajasthan', 'Sikkim', 'Tamil Nadu', 'Telangana', 'Tripura', 'Uttar Pradesh', 'Uttarakhand', 'West Bengal', 'Andaman and Nicobar Islands', 'Chandigarh', 'Dadra and Nagar Haveli', 'Daman and Diu', 'Delhi', 'Lakshadweep', 'Puducherry'
@fzaninotto
fzaninotto Jan 5, 2017 Owner

please split the line by capital letter, and order alphabetically

@jiveshsg
jiveshsg Jan 5, 2017

The administrative region equivalent of "states" in India consists of "states" plus "union territories", therefore the list is arranged alphabetically in two batches where the last 7 entries are union territories (form of states but governed by the central government, with exception of Delhi, i.e. the the capital as well as union territory, also has separate government). So this was the correct way of doing this in my opinion.

Also, please give an example of what do you mean by splitting the line by capital letter. Is is like the following?

'Andhra
Pradesh', ...
@fzaninotto
fzaninotto Jan 5, 2017 Owner

Gotcha. For the line splitting, it's more like

'Andhra Pradesh', 'Arunachal Pradesh', 'Assam',
'Bihar',
'Chhattisgarh',
'Goa', 'Gujarat',
...
@fzaninotto
Owner

You can't use tabs for padding, see the Travis error report.

@fzaninotto fzaninotto merged commit 03eb255 into fzaninotto:master Jan 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fzaninotto
Owner

Thanks!

@jiveshsg jiveshsg deleted the jiveshsg:indian_locale branch Jan 6, 2017
@jiveshsg jiveshsg restored the jiveshsg:indian_locale branch Jan 6, 2017
@jiveshsg jiveshsg deleted the jiveshsg:indian_locale branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment