Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed typo/mistake in variable name in relation handling with Doctrine #24

Merged
merged 1 commit into from Nov 28, 2011

Conversation

Projects
None yet
2 participants
Contributor

jpauli commented Nov 28, 2011

No description provided.

fzaninotto added a commit that referenced this pull request Nov 28, 2011

Merge pull request #24 from jpauli/patch-1
Fixed typo/mistake in variable name in relation handling with Doctrine

@fzaninotto fzaninotto merged commit 1583909 into fzaninotto:master Nov 28, 2011

Owner

fzaninotto commented Nov 28, 2011

Thanks !

@jpauli jpauli commented on the diff Nov 28, 2011

src/Faker/ORM/Doctrine/EntityPopulator.php
@@ -76,7 +76,7 @@ class EntityPopulator
if (!$this->class->isIdentifier($assocName) || !$this->class->isCollectionValuedAssociation($assocName)) {
@jpauli

jpauli Nov 28, 2011

Contributor

By the way, I dont really understand that line.
For me, it does the opposite that what it has to do. For example, I have to delete these lines for the relations to be handled.

@fzaninotto

fzaninotto Nov 28, 2011

Owner

You'll have to ask the author of the original PR, @beberlei.

@jpauli

jpauli Nov 28, 2011

Contributor

Ok, on it

mgriffin pushed a commit to mgriffin/Faker that referenced this pull request Feb 19, 2014

Merge pull request #24 from jpauli/patch-1
Fixed typo/mistake in variable name in relation handling with Doctrine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment