Skip to content

Fixed typo/mistake in variable name in relation handling with Doctrine #24

Merged
merged 1 commit into from Nov 28, 2011

2 participants

@jpauli
jpauli commented Nov 28, 2011

No description provided.

@fzaninotto fzaninotto merged commit 1583909 into fzaninotto:master Nov 28, 2011
@fzaninotto
Owner

Thanks !

@jpauli jpauli commented on the diff Nov 28, 2011
src/Faker/ORM/Doctrine/EntityPopulator.php
@@ -76,7 +76,7 @@ class EntityPopulator
if (!$this->class->isIdentifier($assocName) || !$this->class->isCollectionValuedAssociation($assocName)) {
@jpauli
jpauli added a note Nov 28, 2011

By the way, I dont really understand that line.
For me, it does the opposite that what it has to do. For example, I have to delete these lines for the relations to be handled.

@fzaninotto
Owner
fzaninotto added a note Nov 28, 2011

You'll have to ask the author of the original PR, @beberlei.

@jpauli
jpauli added a note Nov 28, 2011

Ok, on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.