Skip to content

Remove potentially offensive word from last name list #260

Merged
merged 1 commit into from Feb 28, 2014

2 participants

@joshuajabbour

Found it quite surprising to have a company called "Jewess Group" in my fake data. I'm not sure if this is an actual real last name or not, but even if it is, since the last name provider is used as the basis for other providers which might be lacking in context, maybe it should just be removed.

@joshuajabbour joshuajabbour Remove potentially offensive word from last name list.
Found it quite weird to have a company called "Jewess Group" in my fake data, and could see how this might be offensive to some.

I'm not sure if this is an actual real last name or not, but since the last name provider is used as the basis for other providers which might be lacking in context, maybe it should just be removed.
0a0ed16
@fzaninotto
Owner

This is the same list as found in Perl and Ruby Faker libs, although it was removed from Ruby Faker some time ago.

This is why we need a reference to the data source in each provider, to check whether it's a justified name or not.

@fzaninotto fzaninotto merged commit ec11415 into fzaninotto:master Feb 28, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.