Add DDSCAPS_COMPLEX when saving .dds files #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, having mipmaps implies DDSCAPS_COMPLEX. This is a fix so the file opens correctly in RenderDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I use RenderDoc to view .dds files. I was using gli to generate a .dds file that contains a mipmap chain of cubemaps, and I noticed that my file wasn't being detected as a cubemap in RenderDoc (eventhough the files generated by cfmt where recognized correctly).
So I researched how they do it in cmft: https://github.com/dariomanesku/cmft/blob/cad5f31bac66fd05987d667af62311c444df6d46/src/cmft/image.cpp#L1113
Apparently, having mipmaps or having cubemaps implies the flag DDSCAPS_COMPLEX. I would have never figured that out from the documentation.
With this small change RenderDoc seems to recognize the generated files correctly.