Fix glm::rotate for GLM_FORCE_QUAT_DATA_XYZW configuration #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GLM_FORCE_QUAT_DATA_XYZW doesn't simply change the data layout, it also changes the meaning of quat constructor. This means that every call inside glm itself that passes 4 arguments needs to check that define. This change fixes glm::rotate specifically by relying on scalar+vector ctor (which is stable across configurations), although there are other instances in glm that are likely problematic eg glm::cross.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLM_FORCE_QUAT_DATA_XYZW doesn't simply change the data layout, it also changes the meaning of quat constructor.
This means that every call inside glm itself that passes 4 arguments needs to check that define.
This change fixes glm::rotate specifically by relying on scalar+vector ctor (which is stable across configurations), although
there are other instances in glm that are likely problematic eg glm::cross.