New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"glm::decompose()" is using float-type instead of templated-type #869

Open
cofenberg opened this Issue Feb 10, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@cofenberg
Copy link

cofenberg commented Feb 10, 2019

"glm::decompose()" is using float-type instead of templated-type in line

  • "float root, trace = Row[0].x + Row[1].y + Row[2].z;"

Resolved by changing to

  • "T root, trace = Row[0].x + Row[1].y + Row[2].z;"

(line 156 of "glm\gtx\matrix_decompose.inl" in latest version, last changed 7 August 2018 - commit 8c9d16d)

Noticed this when adding 64 bit world space position support to my spare time renderer project.

cofenberg added a commit to cofenberg/unrimp that referenced this issue Feb 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment