Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users mark strings as "urgent" #10

Closed
g3rv4 opened this issue Apr 9, 2018 · 8 comments · Fixed by #32

Comments

@g3rv4
Copy link
Owner

commented Apr 9, 2018

Allow users to mark strings as "urgent", so that translators can focus on those. See the convo on chat.

We have a bunch of strings that don't appear on our international sites. This feature would let regular users mark a string as urgent when they spot it somewhere.

Ideally... they could provide a url!

@g3rv4 g3rv4 added the enhancement label Apr 9, 2018

@topcatarg

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

Steps to enhancement:

  • Migrations

Add class 006 - AddBooleanUrgentToStringsTable: add a boolean field to this table to allow urgent mark (Optional, add another field for the URL)

  • BackEnd

Traducir.Api:

on StringsController add a function to allow a marking a string as urgent (optional, get an url for the string). This will only put true on the string on the database.
When a string is reviewed, set urgent to false (or wait for the pull to set to false).

  • FrontEnd

Add a button on the grid to allow setting a string to Urgent. This could be a button or a checkbox. (checkbox maybe is a better solution).

@g3rv4

This comment has been minimized.

Copy link
Owner Author

commented Apr 13, 2018

You'd also need to:

  • Ensure the cache is populated with the field.
  • Update the cache when a field is deemed urgent.
  • Always sort the response so that urgent fields come first.
  • Initially, give any user the ability to make any string urgent, and make any filter non urgent.
  • LOG EVERY-FREAKING-THING
@topcatarg

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

Also

  • add an urgent filter to main page
@g3rv4

This comment has been minimized.

Copy link
Owner Author

commented Apr 13, 2018

I don't think it needs to be a filter if we always show them first, right?

@topcatarg

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

Ok. no filter them 👍

@Pikoh

This comment has been minimized.

Copy link

commented Apr 13, 2018

I would give the user the option to filter by urgent. It's not that much work and would be a nice feature.

@g3rv4

This comment has been minimized.

Copy link
Owner Author

commented Apr 13, 2018

@Pikoh oh, you do have a point... how would you discover urgent strings that are already translated and don't have a pending suggestion otherwise? (thinking about bad translations)

@Pikoh

This comment has been minimized.

Copy link

commented Apr 13, 2018

That could happen indeed. And,as i said, it's not that much work :)

g3rv4 added a commit that referenced this issue Apr 15, 2018

@g3rv4 g3rv4 closed this in #32 Apr 15, 2018

g3rv4 added a commit that referenced this issue Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.