Issue #128: Create separate email and url fields #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relequestual
approved these changes
Nov 29, 2016
|
Anyone else willing to approve this PR so I can merge? |
fschiettecatte
approved these changes
Dec 1, 2016
sdumitriu
approved these changes
Dec 1, 2016
There was a problem hiding this comment.
Now that we have a dedicated email field, I wonder if href can be made non-mandatory, and at least one of href and email mandatory. This would be backwards incompatible, so I'd say at least for the 1.x series, href should still be mandatory, so that older protocol implementations don't get confused.
sdumitriu
approved these changes
Aug 8, 2017
The ordered list was out of place and didn't continue when broken by a sublist. Also an ordered list with a sub unordered list didn't indent well and was hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.