New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse fails to parse logs generated on Linux with DynamoRIO 7.0.0-RC1 #10

Closed
fmagin opened this Issue Aug 29, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@fmagin
Contributor

fmagin commented Aug 29, 2017

A log file that is generated with DynamoRIO 7.0.0-RC1 on Linux has a different header than on Windows and Lighthouse fails to account for this.
The first lines on those log files look like this and lack some entries (probably) due to this: https://github.com/DynamoRIO/dynamorio/blob/master/ext/drcovlib/modules.c#L388

DRCOV VERSION: 2
DRCOV FLAVOR: drcov-64
Module Table: version 2, count 6
Columns: id, base, end, entry, path
0, 0x0000000000400000, 0x0000000000621000, 0x0000000000404030, /usr/bin/ls

Actual error thrown is

line 307, in _parse_module_v2
    self.checksum  = int(data[4], 16)
ValueError: invalid literal for int() with base 16: '/usr/bin/ls'

log.zip

@gaasedelen

This comment has been minimized.

Show comment
Hide comment
@gaasedelen

gaasedelen Aug 29, 2017

Owner

Fixed in cfef581, will be included in the v0.6 release.

Thanks for the report :-)

Owner

gaasedelen commented Aug 29, 2017

Fixed in cfef581, will be included in the v0.6 release.

Thanks for the report :-)

@gaasedelen gaasedelen closed this Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment