Allow copy operations to work on multiple selected functions #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaasedelen
requested changes
Dec 17, 2017
| gui_rename_function(function_addresses[0]) | ||
|
|
||
| # handle the 'Copy name and address' or 'Copy names and addresses' action | ||
| elif action == self._action_copy_name_and_address or action == self._action_copy_names_and_addresses: |
There was a problem hiding this comment.
Please change to:
elif action in [self._action_copy_name_and_address, self._action_copy_names_and_addresses]:
...
| copy_to_clipboard(function_name_and_address) | ||
|
|
||
| # handle the 'Copy name' or 'Copy names' action | ||
| elif action == self._action_copy_name or action == self._action_copy_names: |
There was a problem hiding this comment.
Same as comment above,
elif action in [self._action_copy_name, self._action_copy_names]:
...
| elif action == self._action_copy_address: | ||
| address_string = "0x%X" % function_address | ||
| # handle the 'Copy address' or 'Copy addresses' action | ||
| elif action == self._action_copy_address or action == self._action_copy_addresses: |
There was a problem hiding this comment.
Same as the other two comments!
| @@ -327,9 +327,14 @@ def _ui_init_ctx_menu_actions(self): | |||
|
|
|||
| # function actions | |||
| self._action_rename = QtWidgets.QAction("Rename", None) | |||
| self._action_copy_name_and_address = QtWidgets.QAction("Copy name and address", None) | |||
There was a problem hiding this comment.
Move this action/member definition to be after self._action_copy_address
| self._action_copy_name = QtWidgets.QAction("Copy name", None) | ||
| self._action_copy_address = QtWidgets.QAction("Copy address", None) | ||
|
|
||
| self._action_copy_names_and_addresses = QtWidgets.QAction("Copy names and addresses", None) |
There was a problem hiding this comment.
Same as above, move this definition after self._action_copy_addresses
|
This seems like a reasonable request to me :-) I've made a few nitpicks on code style and readability, but nothing major. I'd also like you to make the PR to the develop branch where I work on vNext / new features. Master is reserved for major releases or hotfixes. Thanks for the PR! |
paulsapps
force-pushed
the
feature_copy_multiple_function_name_and_addresses
branch
from
9041ccf
to
f5c657e
Compare
paulsapps
force-pushed
the
feature_copy_multiple_function_name_and_addresses
branch
from
f5c657e
to
3024fd2
Compare
|
Fixed.. I think :)? |
|
Thanks, looks good to me |
paulsapps
deleted the
feature_copy_multiple_function_name_and_addresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Allows "copy name", "copy address" to work with multiple selected functions. Also adds "copy name and address" for single/multiple functions.