New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copy operations to work on multiple selected functions #28

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
2 participants
@paulsapps
Contributor

paulsapps commented Dec 17, 2017

Allows "copy name", "copy address" to work with multiple selected functions. Also adds "copy name and address" for single/multiple functions.

@gaasedelen

a few nitpicks on code style & readability

Show outdated Hide outdated plugin/lighthouse/ui/coverage_overview.py Outdated
Show outdated Hide outdated plugin/lighthouse/ui/coverage_overview.py Outdated
Show outdated Hide outdated plugin/lighthouse/ui/coverage_overview.py Outdated
Show outdated Hide outdated plugin/lighthouse/ui/coverage_overview.py Outdated
Show outdated Hide outdated plugin/lighthouse/ui/coverage_overview.py Outdated
@gaasedelen

This comment has been minimized.

Show comment
Hide comment
@gaasedelen

gaasedelen Dec 17, 2017

Owner

This seems like a reasonable request to me :-)

I've made a few nitpicks on code style and readability, but nothing major. I'd also like you to make the PR to the develop branch where I work on vNext / new features. Master is reserved for major releases or hotfixes.

Thanks for the PR!

Owner

gaasedelen commented Dec 17, 2017

This seems like a reasonable request to me :-)

I've made a few nitpicks on code style and readability, but nothing major. I'd also like you to make the PR to the develop branch where I work on vNext / new features. Master is reserved for major releases or hotfixes.

Thanks for the PR!

@paulsapps paulsapps changed the base branch from master to develop Dec 18, 2017

@paulsapps

This comment has been minimized.

Show comment
Hide comment
@paulsapps

paulsapps Dec 18, 2017

Contributor

Fixed.. I think :)?

Contributor

paulsapps commented Dec 18, 2017

Fixed.. I think :)?

@gaasedelen

This comment has been minimized.

Show comment
Hide comment
@gaasedelen

gaasedelen Dec 18, 2017

Owner

Thanks, looks good to me 👍

Owner

gaasedelen commented Dec 18, 2017

Thanks, looks good to me 👍

@gaasedelen gaasedelen merged commit f2dff09 into gaasedelen:develop Dec 18, 2017

@paulsapps paulsapps deleted the paulsapps:feature_copy_multiple_function_name_and_addresses branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment