Improve frida coverage saving #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge upstream
The most bug prone part of frida (in our usage) seems to be process detatching. Previously the script would detatch and then persist all coverage data once detatching had succeeded. This of course means that if detatching fails or hangs, all collected coverage is lost. This is Not Good. This commit adds a SIGINT handler which persists the existing coverage before calling `_exit(1)`. While this doesn't seem to be an especially quick operation, it does save the coverage before exiting. This commit does not address Windows usage, or processes exiting in ways other than SIGINT.
|
🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save coverage even when you control-c to exit frida