New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve frida coverage saving #39

Merged
merged 2 commits into from Jul 10, 2018

Conversation

Projects
None yet
3 participants
@yrp604
Contributor

yrp604 commented Jul 10, 2018

Save coverage even when you control-c to exit frida

yrp604 added some commits Jul 10, 2018

Make coverage saving more robust
The most bug prone part of frida (in our usage) seems to be process
detatching. Previously the script would detatch and then persist all
coverage data once detatching had succeeded. This of course means that
if detatching fails or hangs, all collected coverage is lost. This is
Not Good.

This commit adds a SIGINT handler which persists the existing coverage
before calling `_exit(1)`. While this doesn't seem to be an especially
quick operation, it does save the coverage before exiting.

This commit does not address Windows usage, or processes exiting in ways
other than SIGINT.

@gaasedelen gaasedelen merged commit d8db54d into gaasedelen:master Jul 10, 2018

@agustingianni

This comment has been minimized.

Show comment
Hide comment
@agustingianni

agustingianni Jul 13, 2018

Contributor

🔥

Contributor

agustingianni commented Jul 13, 2018

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment