Added python3 support#62
Conversation
|
Sorry for the merge conflicts on the dev branch. I started to re-architect some stuff, and there is more coming 😅. I'll try to merge your stuff in before my commit storm hits. I should have some time to test it tonight and tomorrow. I am also kind of surprised. This is fewer changes than I thought Py3 compatibility was going to take. It was also on the roadmap for the few binja users that choose to use a Python 3 interpreter (#62) |
|
I had a chance to look at this today and will not accept it outright. My chief complaint is the use of Considering how few items we need from Care to test?? |
|
I switched my Binja env over to 3.6 and got it set up with PyQt5. Needed a few more fixups, but seems to work. Good enough for dev ¯\_(ツ)_/¯ |
This pull requests adds python3 support while keeping python2 compatibility.
Please note that it works for my needs for adding lighthouse to https://github.com/radareorg/cutter however I did not really try it on other disassembler with python2, so I suggest to heavily test it before :)