Support more evil-cleverparens commands #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for another bunch of evil-cleverparens commands. These commands don't appear in the code, because they didn't require any handlers: (they work) - evil-cp-backward-up-sexp - evil-cp-up-sex - evil-cp-backward-symbol-begin - evil-cp-forward-symbol-end - evil-cp-backward-sexp - evil-cp-forward-sexp - evil-cp-forward-symbol-begin - evil-cp-previous-opening - evil-cp-next-closing - evil-cp-next-opening - evil-cp-previous-closing - evil-cp-beginning-of-defun - evil-cp-end-of-defun - evil-cp-backward-symbol-end - evil-cp-toggle-balanced-yank - evil-cp-yank-sexp - evil-cp-yank-enclosing These commands are not supported, see comments in the code: - evil-cp-delete-backward-word - evil-cp-change-whole-line - evil-cp-yank-line - evil-cp-override
gabesoft
added a commit
that referenced
this pull request
Nov 26, 2015
Support more evil-cleverparens commands
|
Great work. I may start using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second and final batch of evil-cleverparens. I believe I covered all of evil-cp's commands, if I have left any it shouldn't be hard to add them. There are still four commands that don't integrate with evil-mc, see details below.
These commands work, but don't appear in the code because they didn't require any handlers:
evil-cp-backward-up-sexpevil-cp-up-sexpevil-cp-backward-symbol-beginevil-cp-forward-symbol-endevil-cp-backward-sexpevil-cp-forward-sexpevil-cp-forward-symbol-beginevil-cp-previous-openingevil-cp-next-closingevil-cp-next-openingevil-cp-previous-closingevil-cp-beginning-of-defunevil-cp-end-of-defunevil-cp-backward-symbol-endevil-cp-toggle-balanced-yankevil-cp-yank-sexpevil-cp-yank-enclosingThese commands are not supported:
evil-cp-delete-backward-word: I added the same handler that evil-delete-backward-word has, but it doesn't seem to work.evil-cp-change-whole-line: evil-change-whole-line doesn't have a handler eitherevil-cp-yank-line: evil-yank-line doesn't have a handler eitherevil-cp-override: didn't figure how to make a proper handler for this one, see detailed comment in the code.A technical git-related note: I rebased the changes from master before adding the new commit. Git didn't show any errors, so it's probably fine, but you may want to double-check that merging this PR won't erase existing code.