Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows setenv check #1475

Merged
merged 1 commit into from Mar 18, 2020
Merged

Fix Windows setenv check #1475

merged 1 commit into from Mar 18, 2020

Conversation

@Crunkle
Copy link
Contributor

Crunkle commented Mar 18, 2020

Use the generic Windows macro here to fix compilation on non-MSVC toolchains. The setenv is not guaranteed available under MinGW and should also use putenv.

@gabime gabime merged commit 2c5c96e into gabime:v1.x Mar 18, 2020
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@gabime

This comment has been minimized.

Copy link
Owner

gabime commented Mar 18, 2020

Thanks. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.