From 2236d69e38d3096dc54612ac24558b2355d5ff16 Mon Sep 17 00:00:00 2001
From: Gabriel Musat <gb.mt.me@gmail.com>
Date: Wed, 31 Jan 2024 07:54:26 +0100
Subject: [PATCH] disable if else in gocritic lint

---
 .golangci.yml             | 3 +++
 cmd/root.go               | 8 +++-----
 internal/js/workspaces.go | 1 -
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.golangci.yml b/.golangci.yml
index dbd6fed..9154ed1 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -11,6 +11,9 @@ linters-settings:
     check-all: true
   goimports:
     local-prefixes: dep-tree
+  gocritic:
+    disabled-checks:
+      - ifElseChain
   revive:
     confidence: 0.8
 
diff --git a/cmd/root.go b/cmd/root.go
index 41e8e12..369be22 100644
--- a/cmd/root.go
+++ b/cmd/root.go
@@ -151,13 +151,11 @@ func filesFromArgs(args []string) ([]string, error) {
 		abs, err := filepath.Abs(arg)
 		if err != nil {
 			errs = append(errs, err)
-			continue
-		}
-		if !utils.FileExists(abs) {
+		} else if !utils.FileExists(abs) {
 			errs = append(errs, fmt.Errorf("file %s does not exist", arg))
-			continue
+		} else {
+			result = append(result, abs)
 		}
-		result = append(result, abs)
 	}
 	if len(result) == 0 {
 		if len(errs) == 1 {
diff --git a/internal/js/workspaces.go b/internal/js/workspaces.go
index 32c67eb..ee56939 100644
--- a/internal/js/workspaces.go
+++ b/internal/js/workspaces.go
@@ -99,7 +99,6 @@ func (w *Workspaces) ResolveFromWorkspaces(unresolved string) (string, error) {
 	var pkgJson *packageJson
 	for {
 		entry, ok := w.ws[firstSlice]
-		//nolint:gocritic
 		if ok {
 			pkgJson = entry
 			break