Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavMenu does not work with TypeScript #63

Closed
gabrielbull opened this issue Jul 26, 2016 · 5 comments
Closed

NavMenu does not work with TypeScript #63

gabrielbull opened this issue Jul 26, 2016 · 5 comments
Labels

Comments

@gabrielbull
Copy link
Owner

I separated the two issues. Reference: Issue #61

Also, I started writing typings for react-desktop thinking it was the reason I couldn't get my NavMenu working, but it still didn't (called setstate() on an unmounted component) work (and my definitions are neither done nor guaranteed perfect).

Did you get it to work? Your example converted to ES6 works fine

@erichiller
Copy link

No, unfortunately, I am still having the same issue. I am not sure on this one, is your gist from my typescript directly transpiled?

@gabrielbull
Copy link
Owner Author

I transpiled by hand to ES6.

@erichiller
Copy link

Here I've done one I transpiled into commonjs - one into es6 -- they look proper and nearly the same, but rather than maintaining the jsx syntax, it is replaced with the underlying javascript it would appear. (ala React.createElement( windows_1.NavPane, for <NavPane>. I can not see anything off here?

@erichiller
Copy link

I figured this out on my side - it was user error - I was using it improperly, however it did cause me to write a lot more definitions for typescript - I will get these to you soon. Thanks - Eric

@gabrielbull
Copy link
Owner Author

Cool thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants