Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP solution for TypeError: wrap_socket() missing 1 required positional argument: 'sock' #393

Merged
merged 4 commits into from Mar 10, 2020

Conversation

@gabrielfalcao
Copy link
Owner

gabrielfalcao commented Mar 10, 2020

takes code from #290

closes #345
closes #290

takes code from #290
@gabrielfalcao gabrielfalcao self-assigned this Mar 10, 2020
@gabrielfalcao gabrielfalcao changed the title WIP solution for ypeError: wrap_socket() missing 1 required positional argument: 'sock' WIP solution for TypeError: wrap_socket() missing 1 required positional argument: 'sock' Mar 10, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #393 into master will increase coverage by 0.91%.
The diff coverage is 70.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
+ Coverage   83.95%   84.86%   +0.91%     
==========================================
  Files           6        6              
  Lines         829      846      +17     
  Branches      126      127       +1     
==========================================
+ Hits          696      718      +22     
+ Misses         90       87       -3     
+ Partials       43       41       -2     
Impacted Files Coverage Δ
httpretty/core.py 84.39% <70.96%> (+1.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3ca1d...9bbe387. Read the comment docs.

@gabrielfalcao gabrielfalcao merged commit 7cfb0c3 into master Mar 10, 2020
0 of 3 checks passed
0 of 3 checks passed
build build
Details
build build
Details
Codacy/PR Quality Review Hang in there, Codacy is reviewing your Pull request.
Details
@nicolasmota

This comment has been minimized.

Copy link

nicolasmota commented Mar 24, 2020

I'm interested in this fix. Do you have any idea when the release will be posted?

@gabrielfalcao

This comment has been minimized.

Copy link
Owner Author

gabrielfalcao commented Mar 24, 2020

Hopefully tomorrow 🙏

@nicolasmota

This comment has been minimized.

Copy link

nicolasmota commented Mar 25, 2020

nice! I'll wait.

@gabrielfalcao

This comment has been minimized.

Copy link
Owner Author

gabrielfalcao commented Mar 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.