Skip to content

Loading…

The New Parser #429

Open
danni opened this Issue · 8 comments

2 participants

@danni
Collaborator

This is a tracking bug for the new Lettuce parser I've been working on.

https://github.com/infoxchange/lettuce/tree/new-parser

This branch includes:

  • rebuild of the parser using pyparsing
  • rebuild of the lettuce core to clean up execution, makes extensive use of try/except/finally.
  • rebuild of the coloured shell outputter using blessings (much easier to read)

Where is it at:

  • unit tests pass
  • functional tests appear to be failing out outputting errors
  • need to completely rebuild tests for coloured outputter, again if we use blessings, we should be able to write much easier to understand tests
  • should add more unit tests to exercise all parts of the parser
  • need to start testing against some real Lettuce examples
@danni danni self-assigned this
This was referenced
@danni danni added this to the 0.3 milestone
@danni danni added the release 0.3 label
@adaschevici
Collaborator

@danni
Timer on test_xunit_output.py:test_xunit_output_with_no_steps has increased.
It used to be ~0 and now it is ~0.0003 any ideas on speed improvements?

@adaschevici adaschevici referenced this issue in infoxchange/lettuce
Closed

changed xunit reasons to fail so that it passes #7

@danni
Collaborator
@adaschevici
Collaborator

This scenario is the one where there are no steps defined, it kind of makes sense to have a really short fail time.

@danni
Collaborator

I agree, but for the moment I'm focused on robustness and stability before I profile the code. This said there's not heaps of difference between 0s and 0.0003s, that doesn't phase me too much. Especially as my focus is on making big files much faster. I do notice though that the unit tests take approximately 20x as long though, so it's possible the setup and teardown time is quite high.

@adaschevici
Collaborator

So...resolution would be to change the test slightly (increase fail time)for now and open an issue for it?

@danni
Collaborator

I'd blank the timings out from the tests.

@adaschevici
Collaborator

I think we should keep the test but increase the time, add a new performance issue.

@danni
Collaborator

The pull request is #430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.