Skip to content

Conversation

@gabrielfeo
Copy link
Owner

@gabrielfeo gabrielfeo commented Sep 9, 2025

Follow up to changes of #476. Related to #332.

@gabrielfeo gabrielfeo requested a review from Copilot September 9, 2025 18:58
@gabrielfeo gabrielfeo marked this pull request as ready for review September 9, 2025 18:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a notebook example demonstrating logging functionality and updates test infrastructure to better capture output streams from executed processes.

Key changes:

  • Added a new Logging.ipynb notebook example showing how to enable debug logging in Kotlin Jupyter environments
  • Enhanced test infrastructure to capture both stdout and stderr streams separately from shell commands and notebook executions
  • Updated existing tests to use the new output stream structure

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Shell.kt Modified to return separate stdout/stderr streams instead of just stdout
Jupyter.kt Enhanced to capture output streams from notebook execution
NotebooksTest.kt Added test for logging notebook and updated to use new output structure
ScriptsTest.kt Updated to access stdout from new output stream structure
ExampleProjectTest.kt Updated to access stdout from new output stream structure
ExampleGradleTaskTest.kt Updated to access stdout from new output stream structure
Logging.ipynb New notebook example demonstrating logging functionality
Logging.md Updated documentation with reference to new logging example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gabrielfeo gabrielfeo enabled auto-merge (squash) September 9, 2025 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Job Summary for Gradle

Check PR :: kotlin-tests
Gradle Root Project Requested Tasks Gradle Version Build Outcome Build Scan®
develocity-api-kotlin check 9.0.0 Build Scan published
dak-example-gradle-project dependencies --configuration runtimeClasspath 9.0.0 Build Scan not published
dak-example-gradle-task-main-…
:buildSrc:dependencies --configuration runtimeClasspath 9.0.0 Build Scan not published
dak-example-gradle-project run 9.0.0 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics 9.0.0 Build Scan not published
dak-example-gradle-task-main-…
userBuildPerformanceMetrics --user runner --period=-1d 9.0.0 Build Scan not published

@gabrielfeo gabrielfeo force-pushed the gf/notebook-logging-example branch from 4b33614 to 7d0aedb Compare September 9, 2025 19:16
@gabrielfeo gabrielfeo merged commit d14bab0 into main Sep 9, 2025
7 checks passed
@gabrielfeo gabrielfeo deleted the gf/notebook-logging-example branch September 9, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants