Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
cli: support --experimental-top-level-await in NODE_OPTIONS
PR-URL: nodejs#33495
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
dfabulich authored and codebytere committed Jun 30, 2020
1 parent 36f3ccd commit 53e29e4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions doc/api/cli.md
Expand Up @@ -1185,6 +1185,7 @@ Node.js options that are allowed are:
* `--experimental-policy`
* `--experimental-repl-await`
* `--experimental-specifier-resolution`
* `--experimental-top-level-await`
* `--experimental-vm-modules`
* `--experimental-wasi-unstable-preview1`
* `--experimental-wasm-modules`
Expand Down
3 changes: 2 additions & 1 deletion src/node_options.cc
Expand Up @@ -599,7 +599,8 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(

AddOption("--experimental-top-level-await",
"enable experimental support for ECMAScript Top-Level Await",
&PerIsolateOptions::experimental_top_level_await);
&PerIsolateOptions::experimental_top_level_await,
kAllowedInEnvironment);
AddOption("--harmony-top-level-await", "", V8Option{});
Implies("--experimental-top-level-await", "--harmony-top-level-await");
Implies("--harmony-top-level-await", "--experimental-top-level-await");
Expand Down
4 changes: 4 additions & 0 deletions test/parallel/test-cli-node-options.js
Expand Up @@ -78,6 +78,10 @@ expect('--stack-trace-limit=100',
if (!['arm', 'arm64', 's390x'].includes(process.arch))
expect('--interpreted-frames-native-stack', 'B\n');

// Workers can't eval as ES Modules. https://github.com/nodejs/node/issues/30682
expectNoWorker('--experimental-top-level-await --input-type=module',
'B\n', 'console.log(await "B")');

function expectNoWorker(opt, want, command, wantsError) {
expect(opt, want, command, wantsError, false);
}
Expand Down

0 comments on commit 53e29e4

Please sign in to comment.