Skip to content

Commit

Permalink
test: add common.mustCall() to NAPI exception test
Browse files Browse the repository at this point in the history
Use `common.mustCall()` to confirm that function is invoked.

PR-URL: nodejs#12959
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and Gabriel Schulhof committed Apr 10, 2018
1 parent ce0e121 commit bdd1375
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions test/addons-napi/test_exception/test.js
Expand Up @@ -9,8 +9,6 @@ function throwTheError() {
}
let caughtError;

const throwNoError = common.noop;

// Test that the native side successfully captures the exception
let returnedError = test_exception.returnException(throwTheError);
assert.strictEqual(theError, returnedError,
Expand All @@ -34,13 +32,13 @@ assert.strictEqual(test_exception.wasPending(), true,
' when it was allowed through');

// Test that the native side does not capture a non-existing exception
returnedError = test_exception.returnException(throwNoError);
returnedError = test_exception.returnException(common.mustCall());
assert.strictEqual(undefined, returnedError,
'Returned error is undefined when no exception is thrown');

// Test that no exception appears that was not thrown by us
try {
test_exception.allowException(throwNoError);
test_exception.allowException(common.mustCall());
} catch (anError) {
caughtError = anError;
}
Expand Down

0 comments on commit bdd1375

Please sign in to comment.