From bdd1375155504accbd0e9780b959d79dc241fe33 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Wed, 10 May 2017 19:37:25 -0700 Subject: [PATCH] test: add common.mustCall() to NAPI exception test Use `common.mustCall()` to confirm that function is invoked. PR-URL: https://github.com/nodejs/node/pull/12959 Reviewed-By: Colin Ihrig Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Gibson Fahnestock Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- test/addons-napi/test_exception/test.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/addons-napi/test_exception/test.js b/test/addons-napi/test_exception/test.js index 94f9566a4b341f..ddd1195fa7234a 100644 --- a/test/addons-napi/test_exception/test.js +++ b/test/addons-napi/test_exception/test.js @@ -9,8 +9,6 @@ function throwTheError() { } let caughtError; -const throwNoError = common.noop; - // Test that the native side successfully captures the exception let returnedError = test_exception.returnException(throwTheError); assert.strictEqual(theError, returnedError, @@ -34,13 +32,13 @@ assert.strictEqual(test_exception.wasPending(), true, ' when it was allowed through'); // Test that the native side does not capture a non-existing exception -returnedError = test_exception.returnException(throwNoError); +returnedError = test_exception.returnException(common.mustCall()); assert.strictEqual(undefined, returnedError, 'Returned error is undefined when no exception is thrown'); // Test that no exception appears that was not thrown by us try { - test_exception.allowException(throwNoError); + test_exception.allowException(common.mustCall()); } catch (anError) { caughtError = anError; }