Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag Mismatch for NAR Trainer #10

Closed
Curlykonda opened this issue Jan 14, 2020 · 3 comments
Closed

Flag Mismatch for NAR Trainer #10

Curlykonda opened this issue Jan 14, 2020 · 3 comments

Comments

@Curlykonda
Copy link

Hi,

In the runfile run_nar_train_gcom_local.sh, there seems to be a Flag mismatch.

In the code, only one path is required that should enable loading labels, metadata and embeddings for the ACR:

        tf.logging.info('Loading ACR module assets')
        acr_label_encoders, articles_metadata_df, content_article_embeddings_matrix = \
                load_acr_module_resources(FLAGS.acr_module_resources_path)

In the runfile, however, there are two Flags, for ACR metadata and embeddings, which are unused in the code.

Perhaps the runfile should be adjusted to execute the code properly (e.g. setting acr_module_resources_path), or alternatively, the code must be adjusted two handle the two Flags separately.

@whonor
Copy link

whonor commented Feb 25, 2020

Hi there,
I also have the same problem, as following:

ERROR

I have never edited the resources, is there wrong in resources?
Could anyone answer the question?
Thanks!

@CatcherGG
Copy link

It's not only a flag-mismatch: #9.
There's missing data: nar_label_encoders.

@gabrielspmoreira
Copy link
Owner

Hi. Sorry for the delayed response. The nar_trainer_gcom.py in fact had an issue, requiring some assets that were not available for the G1 dataset (as the raw textual content of the articles could not be released for that dataset). Now, the information required from the ACR module for the NAR training are only the following command line parameters (--acr_module_articles_metadata_csv_path and --acr_module_articles_content_embeddings_pickle_path), which correspond to the files available in the public dataset URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants