New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!important" is missing in split code #23

Closed
ij11 opened this Issue Jan 17, 2018 · 9 comments

Comments

3 participants
@ij11

ij11 commented Jan 17, 2018

Hey i am working currently with splitter version 1.2.3 and after splitting the css file, on all styles the "!important" is lost which will lead to styling issues ... Do you have an idea?

Thanks in advance,

Iris

@Smasherr

This comment has been minimized.

Smasherr commented Jan 17, 2018

I also noticed that the fonticons are missing. For example this selector

.v-ie .base .v-inline-datefield-button:after { content: "\200B"; }

turns into this after splitting:

.v-ie .base .v-inline-datefield-button:after { content: "​"; }

@agabrys agabrys self-assigned this Jan 17, 2018

@agabrys agabrys added the bug label Jan 17, 2018

@agabrys agabrys added this to the 2.0.0 milestone Jan 17, 2018

@agabrys

This comment has been minimized.

Member

agabrys commented Jan 17, 2018

@ij11 Hi, I confirmed the issue. It will be fixed soon 😄

@Smasherr Hi, please do not add another issue to this topic. You should create a new issue instead. I verified and the problem exists, but it is on CSS Parser side. I even found a similar issue: #63 Parsing of content: "\A" corrupts the CSS file. I think you should create a new issue in their backlog.

@Smasherr

This comment has been minimized.

Smasherr commented Jan 17, 2018

@agabrys From my point of view it is the same bug. Me and @ij11 we work together and we compared our input and output css files. Both mentioned things were discovered in the same compare session so I thought they would belong together.
But if you think my part of the issue should be reported to CSS Parser, I can open an issue for them.

@agabrys

This comment has been minimized.

Member

agabrys commented Jan 17, 2018

@Smasherr I checked and CSS Parser returns "" instead of "\200B", so I cannot do anything more. Please create a ticket in their backlog. I always updating dependencies when are new versions so it will be fixed somewhere in the future (if the author of CSS Parser will fix it).

@Smasherr

This comment has been minimized.

Smasherr commented Jan 18, 2018

Let's see if I get support on their issue tracker: https://sourceforge.net/p/cssparser/bugs/85/

agabrys added a commit that referenced this issue Jan 18, 2018

agabrys added a commit that referenced this issue Jan 18, 2018

@agabrys

This comment has been minimized.

Member

agabrys commented Jan 18, 2018

@Smasherr thank you 👍

@ij11 I think that a snapshot with a fix should be available on next Monday (22-January-2018)

agabrys added a commit that referenced this issue Jan 18, 2018

agabrys added a commit that referenced this issue Jan 19, 2018

agabrys added a commit that referenced this issue Jan 19, 2018

agabrys added a commit that referenced this issue Jan 19, 2018

#23 !important missing
- add support for !important
- update changelog
- upgrade Maven Fluido Skin
@agabrys

This comment has been minimized.

Member

agabrys commented Jan 19, 2018

@ij11 I deployed 2.0.0-SNAPSHOT version - please verify it.

@Smasherr

This comment has been minimized.

Smasherr commented Jan 23, 2018

@agabrys Hey, I have tested it yesterday and it worked fine. I couldn't detect any missing important properties. Although I noticed that the newer versions of plugin remove the newlines - is that the desired behavior? It's not critical, but it makes the resulting stylesheets unreadable.

The character escape sequences issue has been resolved in the lastest snapshot of CSS Parser, which should be released at the end of this week. Will you please update the dependency before releasing your plugin?

@agabrys

This comment has been minimized.

Member

agabrys commented Jan 23, 2018

I created a new issue (#26) because we talk about two different problems in one topic.

The plugin adds \n if compress parameter is set to false (default behavior). I checked it and for:

.outlineClr {
	outline: 0;
	outline-style: none;
	outline-width: 0
}

I received:

.outlineClr {
  outline: 0;
  outline-style: none;
  outline-width: 0;
}

The plugin:

  • uses two spaces instead of tabulators
  • remove "unnecessary" white space characters
  • only uses \n to add a new line (can be displayed incorrectly by editors which require other sequences, for example notepad.exe requires \r\n, when Notepad++ displays \n correctly).

I'm closing the ticket because the missing !important problem has been solved.

@agabrys agabrys closed this Jan 23, 2018

@agabrys agabrys changed the title from !important missing to "!important" is missing in split code Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment