Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Belgium holidays to include RDATEs for Ascent and Pentecost monday #2

Closed
Smile4ever opened this issue Dec 29, 2016 · 4 comments
Closed

Comments

@Smile4ever
Copy link

@Smile4ever Smile4ever commented Dec 29, 2016

Currently, the ICS file for Belgium does not contain RDATES for Ascent and Pentecost monday. Could you add these?

@polo2ro
Copy link
Member

@polo2ro polo2ro commented Dec 29, 2016

i will look into it

@polo2ro
Copy link
Member

@polo2ro polo2ro commented Dec 29, 2016

RDATE property is here, you must use files in the "build" folder and not in the data folder.
example with the english version:
https://raw.githubusercontent.com/gadael/icsdb/master/build/en-US/belgium-nonworkingdays.ics

the data folder is used as source to generate the build and does not contain any RDATE

@Smile4ever
Copy link
Author

@Smile4ever Smile4ever commented Dec 29, 2016

Thank you! Please note that Easter Monday does actually have a RDATE in the data folder.

@Smile4ever Smile4ever closed this Dec 29, 2016
@polo2ro
Copy link
Member

@polo2ro polo2ro commented Dec 29, 2016

thanks, this is probably an error or some remaining test values, i will remove it for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.