New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Belgium holidays to include RDATEs for Ascent and Pentecost monday #2

Closed
Smile4ever opened this Issue Dec 29, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@Smile4ever

Currently, the ICS file for Belgium does not contain RDATES for Ascent and Pentecost monday. Could you add these?

@polo2ro

This comment has been minimized.

Show comment
Hide comment
@polo2ro

polo2ro Dec 29, 2016

Member

i will look into it

Member

polo2ro commented Dec 29, 2016

i will look into it

@polo2ro

This comment has been minimized.

Show comment
Hide comment
@polo2ro

polo2ro Dec 29, 2016

Member

RDATE property is here, you must use files in the "build" folder and not in the data folder.
example with the english version:
https://raw.githubusercontent.com/gadael/icsdb/master/build/en-US/belgium-nonworkingdays.ics

the data folder is used as source to generate the build and does not contain any RDATE

Member

polo2ro commented Dec 29, 2016

RDATE property is here, you must use files in the "build" folder and not in the data folder.
example with the english version:
https://raw.githubusercontent.com/gadael/icsdb/master/build/en-US/belgium-nonworkingdays.ics

the data folder is used as source to generate the build and does not contain any RDATE

@Smile4ever

This comment has been minimized.

Show comment
Hide comment
@Smile4ever

Smile4ever Dec 29, 2016

Thank you! Please note that Easter Monday does actually have a RDATE in the data folder.

Thank you! Please note that Easter Monday does actually have a RDATE in the data folder.

@Smile4ever Smile4ever closed this Dec 29, 2016

@polo2ro

This comment has been minimized.

Show comment
Hide comment
@polo2ro

polo2ro Dec 29, 2016

Member

thanks, this is probably an error or some remaining test values, i will remove it for clarity

Member

polo2ro commented Dec 29, 2016

thanks, this is probably an error or some remaining test values, i will remove it for clarity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment