duplicate REGENERATE_METHOD constant in RHL, #807

gaearon · Jan 21, 2018 · 16ec309 · 16ec309
1 parent 23aa1dc
commit 16ec309
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/packages/react-hot-loader/src/babel.js b/packages/react-hot-loader/src/babel.js
@@ -1,4 +1,4 @@
-const { REGENERATE_METHOD } = require('react-stand-in')
+import { REGENERATE_METHOD } from './internal/constants'
 
 const templateOptions = {
   placeholderPattern: /^([A-Z0-9]+)([A-Z0-9_]+)$/,

diff --git a/packages/react-hot-loader/src/internal/constants.js b/packages/react-hot-loader/src/internal/constants.js
@@ -0,0 +1,3 @@
+// the same as before
+const PREFIX = '__reactstandin__'
+export const REGENERATE_METHOD = `${PREFIX}regenerateByEval`
diff --git a/packages/react-hot-loader/test/build.test.js b/packages/react-hot-loader/test/build.test.js
@@ -0,0 +1,8 @@
+import { REGENERATE_METHOD as REGENERATE_METHOD_rhl } from '../src/internal/constants'
+import { REGENERATE_METHOD as REGENERATE_METHOD_std } from 'react-stand-in'
+
+describe('Consistency tests', () => {
+  it('Should be constant con', () => {
+    expect(REGENERATE_METHOD_rhl).toBe(REGENERATE_METHOD_std)
+  })
+})